[jira] [Created] (COCOON-2341) Use ImageIO instead of old com.sun.image.* package in ImageReader

Discussion:

Reynaldo Porras (JIRA)

2014-02-14 23:33:24 UTC

Reynaldo Porras created COCOON-2341:
---------------------------------------

Summary: Use ImageIO instead of old com.sun.image.* package in ImageReader
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.13
Reporter: Reynaldo Porras

Classes from sun.* should not be used as specified in:
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html

ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327

I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.

Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-14 23:35:23 UTC

Permalink

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.13
Reporter: Reynaldo Porras
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-14 23:37:20 UTC

Permalink

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.13
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-14 23:39:19 UTC

Permalink

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-14 23:39:20 UTC

Permalink

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-18 22:15:20 UTC

Permalink

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-18 22:15:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reynaldo Porras updated COCOON-2341:
------------------------------------

Attachment: COCOON-2341.patch

Removal of death code from previous patch.

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-19 13:40:23 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905427#comment-13905427 ]

Francesco Chicchiriccò commented on COCOON-2341:
------------------------------------------------

Patch looks fine to me, and the fact that code works with JDK >= 1.4 meets the recent requirements in Cocoon 2.1.
[~cedric] could you please confirm?

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 08:05:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906737#comment-13906737 ]

Francesco Chicchiriccò commented on COCOON-2341:
------------------------------------------------

Without your patch, building with JDK 7 fails and JDK 6 succeeds with warnings.

With your patch, building with JDK 6 runs smoothly while with JDK 7 the following exception is returned (I am building with all blocks):

Compiling 45 source files to /home/ilgrosso/work/cocoon/2_1_X/build/cocoon/blocks/databases/dest
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/databases/java/org/apache/cocoon/databases/ibatis/ExcaliburDataSourceFactory.java:82: error: DataSourceWrapper is not abstract and does not override abstract method getParentLogger() in CommonDataSource
protected static final class DataSourceWrapper implements DataSource {

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-21 22:29:23 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13908912#comment-13908912 ]

Reynaldo Porras commented on COCOON-2341:
-----------------------------------------

Thanks for looking at issue Francesco. What my patch fixes is the com.sun.image.* as in COCOON-2327. This only allows cocoon-core to compile for java 1.7 and still compile for java 1.4.

The "ExcaliburDataSourceFactory.java:82..." is another issue which is not fixed in this patch. I see there was an ticket opened for that COCOON-2339, but it does not look like it was solved even though it is closed.

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-25 08:19:19 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911382#comment-13911382 ]

Francesco Chicchiriccò commented on COCOON-2341:
------------------------------------------------

Ok, got it: I've just fixed the DataSource problem from COCOON-2327 in [1].

Now, even with your patch, I still have problems in building the CAPTCHA block:

cocoon-block-captcha-compile:
Compiling 1 source file to /home/ilgrosso/work/cocoon/2_1_X/build/cocoon/blocks/captcha/dest
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:33: error: package com.sun.image.codec.jpeg does not exist
import com.sun.image.codec.jpeg.JPEGCodec;
^
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:34: error: package com.sun.image.codec.jpeg does not exist
import com.sun.image.codec.jpeg.JPEGEncodeParam;
^
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:35: error: package com.sun.image.codec.jpeg does not exist
import com.sun.image.codec.jpeg.JPEGImageEncoder;
^
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:301: error: cannot find symbol
JPEGImageEncoder encoder = JPEGCodec.createJPEGEncoder(buffer);
^
symbol: class JPEGImageEncoder
location: class CaptchaReader
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:301: error: cannot find symbol
JPEGImageEncoder encoder = JPEGCodec.createJPEGEncoder(buffer);
^
symbol: variable JPEGCodec
location: class CaptchaReader
/home/ilgrosso/work/cocoon/2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java:302: error: cannot find symbol
JPEGEncodeParam param = encoder.getDefaultJPEGEncodeParam(result);
^
symbol: class JPEGEncodeParam
location: class CaptchaReader
6 errors

Would you mind to apply your fixes in such block as well?
Thanks.

[1] http://svn.apache.org/r1571609

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-25 14:40:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911619#comment-13911619 ]

Reynaldo Porras commented on COCOON-2341:
-----------------------------------------

Thanks Francesco. I wanted to look at the Datasource issue last weekend but the weekend came too short. I'll take a look at the CaptchaReader and I'll send the patch here.

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-28 21:27:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reynaldo Porras updated COCOON-2341:
------------------------------------

Attachment: COCOON-CaptchaReader-sample-sitemap-2341.patch
COCOON-CaptchaReader-2341.patch

Remove com.sun.image.* from CaptchaReader.java
Fix sample sitemap to test CaptchaReader

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch, COCOON-CaptchaReader-2341.patch, COCOON-CaptchaReader-sample-sitemap-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-28 21:51:27 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13916460#comment-13916460 ]

Reynaldo Porras commented on COCOON-2341:
-----------------------------------------

About the "ExcaliburDataSourceFactory.java:82..." issue I found other ways to fix it in other projects commons-dbcp [1] and jackrabbit [2]. I leave it up to you how to fix it, but I thought you may want see what other people did in other projects.

Best Regards.

[1] - https://svn.apache.org/repos/asf/tomcat/sandbox/trunk-resources/res/dbcp/dbcp-java-7.patch
[2] - https://fisheye6.atlassian.com/viewrep/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/util/db/DataSourceWrapper.java?r1&r2=1209581

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Attachments: COCOON-2341.patch, COCOON-CaptchaReader-2341.patch, COCOON-CaptchaReader-sample-sitemap-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-03-01 17:30:19 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò closed COCOON-2341.
------------------------------------------

Resolution: Fixed
Fix Version/s: 2.1.13
Assignee: Francesco Chicchiriccò

Patches applied, thanks!
Now build works fine even with JDK 1.7 - regarding DataSource fix, I'd say we adopted a solution similar to Jackrabbit's.

http://svn.apache.org/r1573201

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2341.patch, COCOON-CaptchaReader-2341.patch, COCOON-CaptchaReader-sample-sitemap-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Cédric Damioli (JIRA)

2014-03-03 15:23:22 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918150#comment-13918150 ]

Cédric Damioli commented on COCOON-2341:
----------------------------------------

Sorry Francesco, I just noticed you asked me to review the patch. I woke up too late ! :)
Thanks for the patches, Reynaldo !

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2341.patch, COCOON-CaptchaReader-2341.patch, COCOON-CaptchaReader-sample-sitemap-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.2#6252)

Hudson (JIRA)

2014-03-16 13:11:44 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937134#comment-13937134 ]

Hudson commented on COCOON-2341:
--------------------------------

SUCCESS: Integrated in Cocoon 2.1.X #95 (See [https://builds.apache.org/job/Cocoon%202.1.X/95/])
[COCOON-2341] Applying provided patches (ilgrosso: http://svn.apache.org/viewvc/?view=rev&rev=1573201)
* /cocoon/branches/BRANCH_2_1_X/src/blocks/captcha/java/org/apache/cocoon/reading/CaptchaReader.java
* /cocoon/branches/BRANCH_2_1_X/src/blocks/captcha/samples/sitemap.xmap
* /cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/reading/ImageReader.java

Post by Reynaldo Porras (JIRA)
Use ImageIO instead of old com.sun.image.* package in ImageReader
-----------------------------------------------------------------
Key: COCOON-2341
URL: https://issues.apache.org/jira/browse/COCOON-2341
Project: Cocoon
Issue Type: Improvement
Components: * Cocoon Core
Affects Versions: 2.1.12
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2341.patch, COCOON-CaptchaReader-2341.patch, COCOON-CaptchaReader-sample-sitemap-2341.patch
http://www.oracle.com/technetwork/java/faq-sun-packages-142232.html
ImageIO is available since java 1.4. I have tested it using java 1.4 version and it works. This change has already be implemented in cocoon 2.2.1 version as in: https://issues.apache.org/jira/browse/COCOON-2327
I have a patch which is pretty much the same as the one in COCOON-2327 only differences are that import of SystemUtils is removed and It is not using generics to keep compatibility with java 1.4.
Additionally this change allows cocoon-core 2.1.13-dev to compile in java 1.7

--
This message was sent by Atlassian JIRA
(v6.2#6252)