Discussion:
[jira] [Created] (COCOON3-126) Make configurable whether xslt transformer component uses LRU cache or not
Jos Snellings (JIRA)
2013-06-25 04:42:20 UTC
Permalink
Jos Snellings created COCOON3-126:
-------------------------------------

Summary: Make configurable whether xslt transformer component uses LRU cache or not
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1


The XSLT pipeline component should be aware of the following setting in <configurator:settings>

<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings (JIRA)
2013-06-25 04:50:21 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jos Snellings updated COCOON3-126:
----------------------------------

Attachment: cocoon3-126.patch

Patch solving the issue from xslt transformer alone.

Not too happy with it:
Should it not be chosen in cocoon-sitemap if an lru
cache is to be used? Leave it up to you.
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: cocoon3-126.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Thorsten Scherler (JIRA)
2013-07-02 22:30:22 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698330#comment-13698330 ]

Thorsten Scherler commented on COCOON3-126:
-------------------------------------------

I do not think it is a good idea to use the spring injection here.

Have a look at http://svn.apache.org/viewvc?view=revision&revision=r1447255 I think passing the config via parameter is much more flexible and do not force to use spring.

Can you attach a patch that is more in the spirit of the commit I linked above?
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: cocoon3-126.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings
2013-07-03 06:28:12 UTC
Permalink
I completely agree !
(see also Simo's idea)


On Wed, Jul 3, 2013 at 12:30 AM, Thorsten Scherler (JIRA)
[
https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698330#comment-13698330]
-------------------------------------------
I do not think it is a good idea to use the spring injection here.
Have a look at
http://svn.apache.org/viewvc?view=revision&revision=r1447255 I think
passing the config via parameter is much more flexible and do not force to
use spring.
Can you attach a patch that is more in the spirit of the commit I linked above?
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or
not
--------------------------------------------------------------------------
Post by Jos Snellings (JIRA)
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: cocoon3-126.patch
The XSLT pipeline component should be aware of the following setting in
<configurator:settings>
Post by Jos Snellings (JIRA)
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled"
value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
--
We should be careful to get out of an experience only the wisdom that is
in it - and stay there, lest we be like the cat that sits down on a hot
stove-lid. She will never sit down on a hot stove-lid again - and that
is well; but also she will never sit down on a cold one any more.
-- Mark Twain
<http://www.brainyquote.com/quotes/quotes/t/thomashobb118630.html>
Jos Snellings (JIRA)
2013-07-19 13:34:49 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713647#comment-13713647 ]

Jos Snellings commented on COCOON3-126:
---------------------------------------

True, so here is a solution that uses the injection in cocoon-sitemap.
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: cocoon3-126.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings (JIRA)
2013-07-19 13:36:48 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jos Snellings updated COCOON3-126:
----------------------------------

Attachment: cocoon-sax-COCOON3-126.patch

Changes in XSLTTransformer.
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: CachingXSLTTransformer.java, cocoon3-126.patch, cocoon-sax-COCOON3-126.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings (JIRA)
2013-07-19 13:36:49 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jos Snellings updated COCOON3-126:
----------------------------------

Attachment: CachingXSLTTransformer.java

The XLSTTransformer with internal LRU cache.
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: CachingXSLTTransformer.java, cocoon3-126.patch, cocoon-sax-COCOON3-126.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings (JIRA)
2013-07-19 13:45:26 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jos Snellings updated COCOON3-126:
----------------------------------

Attachment: cocoon-sitemap-COCOON3-126-2.patch

Changes to PrototypePipelineComponentFactory
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: CachingXSLTTransformer.java, cocoon3-126.patch, cocoon-sax-COCOON3-126.patch, cocoon-sitemap-COCOON3-126-1.patch, cocoon-sitemap-COCOON3-126-2.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Jos Snellings (JIRA)
2013-07-19 13:45:25 UTC
Permalink
[ https://issues.apache.org/jira/browse/COCOON3-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jos Snellings updated COCOON3-126:
----------------------------------

Attachment: cocoon-sitemap-COCOON3-126-1.patch
Post by Jos Snellings (JIRA)
Make configurable whether xslt transformer component uses LRU cache or not
--------------------------------------------------------------------------
Key: COCOON3-126
URL: https://issues.apache.org/jira/browse/COCOON3-126
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-sax
Affects Versions: 3.0.0-beta-1
Reporter: Jos Snellings
Priority: Minor
Fix For: 3.0.0-beta-1
Attachments: CachingXSLTTransformer.java, cocoon3-126.patch, cocoon-sax-COCOON3-126.patch, cocoon-sitemap-COCOON3-126-1.patch
The XSLT pipeline component should be aware of the following setting in <configurator:settings>
<configurator:property name="org.apache.cocoon.sax.lrucache-enabled" value="true|false|True|False"/>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
Loading...