[jira] [Created] (COCOON-2342) Apache license at the beginning cocoon's dojo widgets templates causes: dojo.widget.Parse: error:

Discussion:

Reynaldo Porras (JIRA)

2014-02-18 23:07:19 UTC

Permalink

Reynaldo Porras created COCOON-2342:
---------------------------------------

Summary: Apache license at the beginning cocoon's dojo widgets templates causes: dojo.widget.Parse: error:
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras

Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "

This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.

Issue is caused by the apache license header added to the template files of those widgets.

I found that moving the license header inside of the first html element of the widget fixes the issue.

Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-18 23:17:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Reynaldo Porras updated COCOON-2342:
------------------------------------

Attachment: COCOON-2342.patch

Apache header license moved inside of the first html element of the templates fixes the issue.

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-18 23:17:22 UTC

Permalink

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-19 13:50:19 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905448#comment-13905448 ]

Francesco Chicchiriccò commented on COCOON-2342:
------------------------------------------------

I actually don't see any difference in behavior (using latest Firefox and Chromium on Linux) with or without your patch.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reynaldo Porras (JIRA)

2014-02-19 16:06:22 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905609#comment-13905609 ]

Reynaldo Porras commented on COCOON-2342:
-----------------------------------------

Thanks for your reply Francesco. I am on linux too, specifically fedora 19. It is odd that you cannot reproduce the issue. Basically the steps I followed to reproduce the issue were:

1. Get a fresh checkout of cocoon branch 2.1:
svn co http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X

2. Build cocoon:
./build.sh

3.Run cocoon webapp:
./cocoon.sh

4. Go to any of the links below

http://localhost:8888/samples/blocks/forms/do-multiValueDoubleList.flow
http://localhost:8888/samples/blocks/forms/do-multivalueWithSuggestion.flow

You'll see the widget are not rendered. On firebug console you'll see this error:

- For link http://localhost:8888/samples/blocks/forms/do-multiValueDoubleList.flow:
... [lots of output]
GET http://localhost:8888/_cocoon/resources/forms/js/templates/MultiValueDoubleList.html
dojo.js (line 769)
dojo.widget.Parse: error:
TypeError: this.selectLeft is undefined
}
... [lots of output]

- For link http://localhost:8888/samples/blocks/forms/do-multivalueWithSuggestion.flow:

... [lots of output]
GET http://localhost:8888/_cocoon/resources/forms/js/templates/MultiValueEditorWithSuggestion.html
dojo.js (line 769)
dojo.widget.Parse: error:
TypeError: this.select is undefined
};
... [lots of output]

After path is applied build cocoon (./build.sh) again and run cocoon webapp (./cocoon.sh). Go to the links above and you should see the widgets rendered.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 07:53:19 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò updated COCOON-2342:
-------------------------------------------

Fix Version/s: 2.1.13

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 07:53:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò reassigned COCOON-2342:
----------------------------------------------

Assignee: Francesco Chicchiriccò

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 07:59:28 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò closed COCOON-2342.
------------------------------------------

Resolution: Fixed

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 07:59:23 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906734#comment-13906734 ]

Francesco Chicchiriccò commented on COCOON-2342:
------------------------------------------------

Patch applied: http://svn.apache.org/r1570098

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Francesco Chicchiriccò (JIRA)

2014-02-20 07:59:22 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906733#comment-13906733 ]

Francesco Chicchiriccò commented on COCOON-2342:
------------------------------------------------

Ok, I see the problem: I was confused by the fact that

http://cocoon.zones.apache.org/cocoon21/samples/blocks/forms/do-multivalueWithSuggestion.flow
http://cocoon.zones.apache.org/cocoon21/samples/blocks/forms/do-multiValueDoubleList.flow

works fine: this is evidently because this bug was introduced in 2.1.12 while cocoon zone runs 2.1.12-dev.

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Hudson (JIRA)

2014-02-20 08:13:20 UTC

Permalink

[ https://issues.apache.org/jira/browse/COCOON-2342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906746#comment-13906746 ]

Hudson commented on COCOON-2342:
--------------------------------

SUCCESS: Integrated in Cocoon 2.1.X #91 (See [https://builds.apache.org/job/Cocoon%202.1.X/91/])
[COCOON-2342] Patch applied (ilgrosso: http://svn.apache.org/viewvc/?view=rev&rev=1570098)
* /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/resources/org/apache/cocoon/forms/resources/js/templates/InfoPopup.html
* /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/resources/org/apache/cocoon/forms/resources/js/templates/MultiValueDoubleList.html
* /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/resources/org/apache/cocoon/forms/resources/js/templates/MultiValueEditor.html
* /cocoon/branches/BRANCH_2_1_X/src/blocks/forms/resources/org/apache/cocoon/forms/resources/js/templates/MultiValueEditorWithSuggestion.html

-------------------------------------------------------------------------------------------------
Key: COCOON-2342
URL: https://issues.apache.org/jira/browse/COCOON-2342
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.1.12, 2.1.13
Reporter: Reynaldo Porras
Assignee: Francesco Chicchiriccò
Fix For: 2.1.13
Attachments: COCOON-2342.patch
Get cocoon from http://svn.apache.org/repos/asf/cocoon/branches/BRANCH_2_1_X and test cocoon form examples, specifically "Cocoon multivalue editor with suggestions" or "Cocoon double-list multivalue widget ". You should see that the widgets are not being displayed and in debug console of the browser should appear a message like this "dojo.widget.Parse: error: "
This issue is present in MultiValueDoubleList widget, MultiValueEditorWithsuggestion, MultiValueEditor and InfoPopup.
Issue is caused by the apache license header added to the template files of those widgets.
I found that moving the license header inside of the first html element of the widget fixes the issue.
Test on firefox 27.0 and google chrome 32.0.1700.107.

--
This message was sent by Atlassian JIRA
(v6.1.5#6160)